[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h
From: |
Yaowei Bai |
Subject: |
Re: [Qemu-block] [PATCH 1/3] timer: fix misleading comment in timer.h |
Date: |
Mon, 5 Dec 2016 11:08:28 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 01, 2016 at 04:23:17PM +0100, Paolo Bonzini wrote:
>
>
> On 01/12/2016 14:50, Stefan Hajnoczi wrote:
> > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote:
> >> It's timer to expire, not clock.
> >>
> >> Signed-off-by: Yaowei Bai <address@hidden>
> >> ---
> >> include/qemu/timer.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > For the whole series:
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> >
> > PS: I suggest sending a cover letter "[PATCH 0/3]" in the future. This
> > makes it easy for reviewers to indicate they have reviewed the whole
> > series. Without a cover letter it's ambiguous whether my single
> > Reviewed-by: applies to just this patch or to the whole series - and
> > patch management tools will probably get it wrong too.
> >
>
> I've queued the series for QEMU 2.9. This kind of patch can probably be
> sent to address@hidden, which will simplify their inclusion.
>
> Of course, this is not meant to diminish your contribution! "Trivial"
> patches are important and good comments will also help the next person
> studying QEMU's source code.
Got it from both of you, will correct it in the future, thanks.
>
> Thanks,
>
> Paolo