Re: [Qemu-block] [PATCH v1 09/15] qcow: convert QCow to use QCryptoBlock for encryption

[Max Reitz]

On 03.01.2017 19:27, Daniel P. Berrange wrote:
> This converts the qcow2 driver to make use of the QCryptoBlock
> APIs for encrypting image content. This is only wired up to
> permit use of the legacy QCow encryption format. Users who wish
> to have the strong LUKS format should switch to qcow2 instead.
> 
> With this change it is now required to use the QCryptoSecret
> object for providing passwords, instead of the current block
> password APIs / interactive prompting.
> 
>   $QEMU \
>     -object secret,id=sec0,filename=/home/berrange/encrypted.pw \
>     -drive file=/home/berrange/encrypted.qcow,aes-key-secret=sec0
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/crypto.c       |  10 +++
>  block/crypto.h       |   9 +++
>  block/qcow.c         | 184 
> +++++++++++++++++++++++----------------------------
>  qapi/block-core.json |  17 ++++-
>  4 files changed, 117 insertions(+), 103 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature