[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PULL 04/41] virtio: convert to use DMA api
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PULL 04/41] virtio: convert to use DMA api |
|
Date: |
Thu, 19 Jan 2017 10:05:06 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 18/01/2017 20:10, Michael S. Tsirkin wrote:
>> Coverity reports that ARRAY_SIZE(elem->out_sg) (and all the others too)
>> is wrong because elem->out_sg is a pointer.
>>
>> However, the check is not in the right place and the max_size argument
>> of virtqueue_map_iovec can be removed. The check on in_num/out_num can
>> be moved to qemu_get_virtqueue_element instead, before the call to
>> virtqueue_alloc_element.
>
> I guess the effect of this bug is basically false-positive asserts, correct?
Yes, migration is probably broken in the case where the stream includes
VirtQueueElements.
Paolo