[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v10 05/16] block: Set "share-rw" flag in drive-backu
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH v10 05/16] block: Set "share-rw" flag in drive-backup when sync=none |
Date: |
Thu, 19 Jan 2017 22:38:05 +0800 |
In this case we may open the source's backing image chain multiple
times. Setting share flag means the new open won't try to acquire or
check any lock, once we implement image locking.
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 245e1e1..c97e97f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3177,6 +3177,9 @@ static BlockJob *do_drive_backup(DriveBackup *backup,
BlockJobTxn *txn,
}
if (backup->sync == MIRROR_SYNC_MODE_NONE) {
source = bs;
+ /* FIXME: block layer should really open target with BDRV_O_NO_BACKING
+ * and reuse source's backing chain, if they share one. */
+ flags |= BDRV_O_SHARE_RW;
}
size = bdrv_getlength(bs);
--
2.9.3
- [Qemu-block] [PATCH v10 00/16] block: Image locking series, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 01/16] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 02/16] block: Define BDRV_O_SHARE_RW, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 03/16] qemu-io: Set "share-rw" flag together with read-only, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 04/16] qemu-img: Set "share-rw" flag in read-only commands, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 05/16] block: Set "share-rw" flag in drive-backup when sync=none,
Fam Zheng <=
- [Qemu-block] [PATCH v10 06/16] iotests: 055: Don't attach the drive to vm for drive-backup, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 07/16] iotests: 030: Read-only open image for getting map, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 08/16] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 09/16] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 10/16] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 11/16] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 12/16] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 13/16] tests: Disable image lock in test-replication, Fam Zheng, 2017/01/19
- [Qemu-block] [PATCH v10 14/16] file-posix: Implement image locking, Fam Zheng, 2017/01/19