[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] iotests: record separate timings per format,
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH v2] iotests: record separate timings per format, protocol pair |
Date: |
Tue, 24 Jan 2017 12:38:17 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Jan 03, 2017 at 11:08:39AM -0600, Eric Blake wrote:
> On 01/03/2017 10:05 AM, Daniel P. Berrange wrote:
> > The 'check' program records timings for each test that
> > is run. These timings are only valid, however, for a
> > particular format/protocol combination. So if frequently
> > running 'check' with a variety of different formats or
> > protocols, the times printed can be very misleading.
> >
> > Instead of having a single 'check.time' file, maintain
> > multiple 'check.time-$IMGPROTO-$IMGFMT' files.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> > Changed in v2:
> >
> > - Use a separate file per format/protocol, instead of
> > throwing away data each time format/protocol changes
> > between runs (Eric)
> >
>
> Reviewed-by: Eric Blake <address@hidden>
Ping, any block maintainers want to take this simple patch ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|