[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: honor is_external in Ai
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: honor is_external in AioContext polling |
|
Date: |
Tue, 24 Jan 2017 13:51:33 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 24/01/2017 13:47, Fam Zheng wrote:
>> I'm not sure I understand why this is related. aio_poll() only tries
>> poll mode once, so bdrv_flush would only spin until the fsync is complete.
>
> Right, I was confused. The problematic ones are "drain" style ones that
> tracks
> a inflight counter. The only suspecious one is in v9fs_reset(), otherwise we
> are
> safe!
And v9fs_reset in turn is fine because it doesn't use
virtio_queue_aio_set_host_notifier_handler (so it goes to
event_notifier_set_handler and then iohandler_ctx, not
qemu_get_aio_context()).
Paolo