[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 8/8] hw: Drop superfluous special checks for
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive |
Date: |
Fri, 27 Jan 2017 06:00:32 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/26/2017 10:09 AM, Markus Armbruster wrote:
> We've traditionally rejected orphans here and there, but not
> systematically. For instance, the sun4m machines have an onboard SCSI
> HBA (bus=0), and have always rejected bus>0. Other machines with an
> onboard SCSI HBA don't.
>
> Commit a66c9dc made all orphans trigger a warning, and the previous
> commit turned this into an error. The checks "here and there" are now
> redundant. Drop them.
>
> Note that the one in mips_jazz.c was wrong: it rejected bus > MAX_FD,
> but MAX_FD is the number of floppy drives per bus.
>
> Error messages change from
>
> $ qemu-system-x86_64 -drive if=ide,bus=2
> qemu-system-x86_64: Too many IDE buses defined (3 > 2)
> $ qemu-system-mips64 -M magnum,accel=qtest -drive if=floppy,bus=2,id=fd1
> qemu: too many floppy drives
> $ qemu-system-sparc -M LX -drive if=scsi,bus=1
> qemu: too many SCSI bus
>
> to
>
> $ qemu-system-x86_64 -drive if=ide,bus=2
> qemu-system-x86_64: -drive if=ide,bus=2: machine type does not support
> this drive
> $ qemu-system-mips64 -M magnum,accel=qtest -drive if=floppy,bus=2,id=fd1
> qemu-system-mips64: -drive if=floppy,bus=2,id=fd1: machine type does not
> support this drive
> $ qemu-system-sparc -M LX -drive if=scsi,bus=1
> qemu-system-sparc: -drive if=scsi,bus=1: machine type does not support
> this drive
>
Hm, that's a lot less helpful, isn't it? Can we augment with hints?
- [Qemu-block] [PATCH v2 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work, (continued)
[Qemu-block] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, Markus Armbruster, 2017/01/26
- Re: [Qemu-block] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive,
John Snow <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, Markus Armbruster, 2017/01/27
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, John Snow, 2017/01/27
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, Markus Armbruster, 2017/01/27
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, John Snow, 2017/01/28
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, Markus Armbruster, 2017/01/30
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive, John Snow, 2017/01/30
[Qemu-block] [PATCH v2 2/8] hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus, Markus Armbruster, 2017/01/26
[Qemu-block] [PATCH v2 3/8] hw: Default -drive to if=none instead of ide when ide cannot work, Markus Armbruster, 2017/01/26