Re: [Qemu-block] [PATCH v3 14/18] qcow2: add iotests to cover LUKS encryption support

[Max Reitz]

On 26.01.2017 11:18, Daniel P. Berrange wrote:
> This extends the 087 iotest to cover LUKS encryption when doing
> blockdev-add.
> 
> Two further tests are added to validate read/write of LUKS
> encrypted images with a single file and with a backing file.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  tests/qemu-iotests/087     | 32 ++++++++++++++++-
>  tests/qemu-iotests/087.out | 14 +++++++-
>  tests/qemu-iotests/174     | 76 ++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/174.out | 19 ++++++++++
>  tests/qemu-iotests/175     | 86 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/175.out | 26 ++++++++++++++
>  tests/qemu-iotests/group   |  2 ++
>  7 files changed, 253 insertions(+), 2 deletions(-)
>  create mode 100755 tests/qemu-iotests/174
>  create mode 100644 tests/qemu-iotests/174.out
>  create mode 100755 tests/qemu-iotests/175
>  create mode 100644 tests/qemu-iotests/175.out

[...]

> diff --git a/tests/qemu-iotests/174.out b/tests/qemu-iotests/174.out
> new file mode 100644
> index 0000000..bf1a23a
> --- /dev/null
> +++ b/tests/qemu-iotests/174.out
> @@ -0,0 +1,19 @@
> +QA output created by 174
> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=16777216 
> encryption-format=luks luks-key-secret=sec0 luks-iter-time=10
> +
> +== reading whole image ==
> +read 16777216/16777216 bytes at offset 0
> +16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +
> +== rewriting whole image ==
> +wrote 16777216/16777216 bytes at offset 0
> +16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +
> +== verify pattern ==
> +read 16777216/16777216 bytes at offset 0
> +16 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +
> +== verify open failure with wrong password ==
> +can't open: Invalid password, cannot unlock any keyslot
> +no file open, try 'help open'

This line will need to be removed because of:
https://github.com/XanClic/qemu/commit/d943be0de2168543a3ada81c292f6ff379e71590

Also, the test numbers need to be bumped up (173 and 174 are taken), but
all of these are things the maintainer can fix, so:

Reviewed-by: Max Reitz <address@hidden>


[...]

> +SECRET0="secret,id=sec0,data=astrochicken"
> +SECRET1="secret,id=sec1,data=furby"

You always have the best passwords.

signature.asc
Description: OpenPGP digital signature