[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 4/8] hw: Default -drive to if=none instead of scs
From: |
Markus Armbruster |
Subject: |
[Qemu-block] [PATCH v3 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work |
Date: |
Wed, 15 Feb 2017 11:05:43 +0100 |
Block backends defined with -drive if=scsi are meant to be picked up
by machine initialization code: a suitable frontend gets created and
wired up automatically.
if=scsi drives not picked up that way can still be used with -device
as if they had if=none, but that's unclean and best avoided. Unused
ones produce an "Orphaned drive without device" warning.
A few machine types default to if=scsi, even though they don't
actually have a SCSI HBA. This makes no sense. Change their default
to if=none. Affected machines:
* aarch64/arm: realview-pbx-a9 vexpress-a9 vexpress-a15 xilinx-zynq-a9
Cc: Peter Maydell <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Cc: Alistair Francis <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
---
hw/arm/realview.c | 1 -
hw/arm/vexpress.c | 1 -
hw/arm/xilinx_zynq.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 8eafcca..8c11c7a 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -443,7 +443,6 @@ static void realview_pbx_a9_class_init(ObjectClass *oc,
void *data)
mc->desc = "ARM RealView Platform Baseboard Explore for Cortex-A9";
mc->init = realview_pbx_a9_init;
- mc->block_default_type = IF_SCSI;
mc->max_cpus = 4;
}
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index e057568..c6b1e67 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -752,7 +752,6 @@ static void vexpress_class_init(ObjectClass *oc, void *data)
mc->desc = "ARM Versatile Express";
mc->init = vexpress_common_init;
- mc->block_default_type = IF_SCSI;
mc->max_cpus = 4;
}
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 7dac20d..3985356 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc)
{
mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9";
mc->init = zynq_init;
- mc->block_default_type = IF_SCSI;
mc->max_cpus = 1;
mc->no_sdcard = 1;
}
--
2.7.4
- [Qemu-block] [PATCH v3 0/8] More sensible default for -drive interface type, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 6/8] blockdev: Improve message for orphaned -drive, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 8/8] hw: Drop superfluous special checks for orphaned -drive, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 7/8] blockdev: Make orphaned -drive fatal, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 1/8] hw: Default -drive to if=ide explicitly where it works, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 5/8] hw/arm/highbank: Default -drive to if=ide instead of if=scsi, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 3/8] hw: Default -drive to if=none instead of ide when ide cannot work, Markus Armbruster, 2017/02/15
- [Qemu-block] [PATCH v3 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work,
Markus Armbruster <=
- [Qemu-block] [PATCH v3 2/8] hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus, Markus Armbruster, 2017/02/15