Re: [Qemu-block] [PATCH 53/54] block: Add Error parameter to bdrv_set_backing_hd()

[Max Reitz]

On 21.02.2017 15:58, Kevin Wolf wrote:
> Not all callers of bdrv_set_backing_hd() know for sure that attaching
> the backing file will be allowed by the permission system. Return the
> error from the function rather than aborting.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c               | 27 ++++++++++++++++++++-------
>  block/commit.c        | 14 +++++++-------
>  block/mirror.c        | 16 +++++++++++++++-
>  block/stream.c        |  9 ++++++++-
>  block/vvfat.c         |  2 +-
>  include/block/block.h |  3 ++-
>  6 files changed, 53 insertions(+), 18 deletions(-)

It's a bit unfortunate that bdrv_set_backing_hd() is not atomic, that
is, that the node will no longer have a backing file if the command
fails. Oh well.

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature