[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 0/4] RBD: blockdev-add
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PATCH 0/4] RBD: blockdev-add |
Date: |
Mon, 27 Feb 2017 02:30:37 -0500 |
This series adds blockdev-add for rbd.
However, there is an area that will likely need to change. In the RBD
driver, all options for Ceph are supported, but the qemu driver is not
explicitly aware of all the options.
There are a few options that the QEMU driver cares about and handles, while
the other options are merely split out until their string key/value pairs
and passed along to Ceph. In patches 3 and 4, this patch series does
the same practice, and parses all the extra options as a long string.
For QAPI, this is not acceptable - so I presume the best way to handle it
is with an array schema of structs. I'll reply to the specific patches in
the problem areas, and see what the preference is from an API perspective
to handle this.
Jeff Cody (4):
block/rbd: don't copy strings in qemu_rbd_next_tok()
block/rbd: code movement
block/rbd: parse all options via bdrv_parse_filename
block/rbd: Add blockdev-add support
block/rbd.c | 435 +++++++++++++++++++++++++++++----------------------
qapi/block-core.json | 47 +++++-
2 files changed, 289 insertions(+), 193 deletions(-)
--
2.9.3
- [Qemu-block] [PATCH 0/4] RBD: blockdev-add,
Jeff Cody <=
Re: [Qemu-block] [PATCH 4/4] block/rbd: Add blockdev-add support, Daniel P. Berrange, 2017/02/27
[Qemu-block] [PATCH 1/4] block/rbd: don't copy strings in qemu_rbd_next_tok(), Jeff Cody, 2017/02/27