[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block/mirror: fix broken sparseness detection
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH] block/mirror: fix broken sparseness detection |
Date: |
Mon, 27 Feb 2017 14:03:24 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Feb 27, 2017 at 12:13:14PM -0500, John Snow wrote:
> int64_t is in all likelihood the actual scalar type we want.
> Yep, really.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1219541
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index ca8547b..7b4cfbd 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -386,7 +386,7 @@ static uint64_t coroutine_fn
> mirror_iteration(MirrorBlockJob *s)
> nb_chunks * sectors_per_chunk);
> bitmap_set(s->in_flight_bitmap, sector_num / sectors_per_chunk,
> nb_chunks);
> while (nb_chunks > 0 && sector_num < end) {
> - int ret;
> + int64_t ret;
> int io_sectors, io_sectors_acct;
> BlockDriverState *file;
> enum MirrorMethod {
> --
> 2.9.3
>
Thanks,
Applied to my block branch:
git://github.com/codyprime/qemu-kvm-jtc.git block
-Jeff