Re: [Qemu-block] [PATCH v3 35/44] commit: Add filter-node-name to block-commit

[Max Reitz]

On 28.02.2017 13:54, Kevin Wolf wrote:
> Management tools need to be able to know about every node in the graph
> and need a way to address them. Changing the graph structure was okay
> because libvirt doesn't really manage the node level yet, but future
> libvirt versions need to deal with both new and old version of qemu.
> 
> This new option to blockdev-commit allows the client to set a node-name
> for the automatically inserted filter driver, and at the same time
> serves as a witness for a future libvirt that this version of qemu does
> automatically insert a filter driver.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/commit.c            |  5 +++--
>  block/mirror.c            |  3 ++-
>  block/replication.c       |  2 +-
>  blockdev.c                | 10 +++++++---
>  include/block/block_int.h | 13 ++++++++++---
>  qapi/block-core.json      |  8 +++++++-
>  qemu-img.c                |  4 ++--
>  7 files changed, 32 insertions(+), 13 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature