[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_json
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse |
|
Date: |
Tue, 28 Feb 2017 17:51:52 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
> Ignoring errors first, then asserting success is suboptimal. Pass
> &error_abort instead, so we abort earlier, and hopefully get more
> useful clues on what's wrong.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json(), (continued)
- [Qemu-block] [PATCH 23/24] keyval: Restrict key components to valid QAPI names, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, Markus Armbruster, 2017/02/27
- Re: [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse,
Kevin Wolf <=
- [Qemu-block] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no", Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 18/24] block: Initial implementation of -blockdev, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 05/24] test-keyval: Cover use with qobject input visitor, Markus Armbruster, 2017/02/27