Re: [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error_a

From:	Kevin Wolf
Subject:	Re: [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()
Date:	Tue, 28 Feb 2017 18:09:19 +0100
User-agent:	Mutt/1.5.21 (2010-09-15)

Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
> qmp_deserialize() calls qobject_from_json() ignoring errors.  It
> passes the result to qobject_input_visitor_new(), which asserts it's
> not null.  Therefore, we can just as well pass &error_abort to
> qobject_from_json().
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), (continued)
- [Qemu-block] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Kevin Wolf, 2017/02/28
  - Re: [Qemu-block] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Eric Blake, 2017/02/28
    - Re: [Qemu-block] [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/02/28
- [Qemu-block] [PATCH 22/24] qapi: New parse_qapi_name(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 22/24] qapi: New parse_qapi_name(), Kevin Wolf, 2017/02/28
    - Re: [Qemu-block] [Qemu-devel] [PATCH 22/24] qapi: New parse_qapi_name(), Markus Armbruster, 2017/02/28
  - Re: [Qemu-block] [PATCH 22/24] qapi: New parse_qapi_name(), Eric Blake, 2017/02/28
- [Qemu-block] [PATCH 07/24] qapi: Factor out common qobject_input_get_keyval(), Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Kevin Wolf <=
- [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json(), Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json(), Kevin Wolf, 2017/02/28
  - Re: [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json(), Eric Blake, 2017/02/28
    - Re: [Qemu-block] [Qemu-devel] [PATCH 14/24] check-qjson: Test errors from qobject_from_json(), Markus Armbruster, 2017/02/28
- [Qemu-block] [PATCH 23/24] keyval: Restrict key components to valid QAPI names, Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 23/24] keyval: Restrict key components to valid QAPI names, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c, Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane, Markus Armbruster, 2017/02/27
  - Re: [Qemu-block] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane, Kevin Wolf, 2017/02/28

Prev by Date: Re: [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json()
Next by Date: Re: [Qemu-block] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane
Previous by thread: [Qemu-block] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json()
Next by thread: [Qemu-block] [PATCH 14/24] check-qjson: Test errors from qobject_from_json()
Index(es):
- Date
- Thread