Re: [Qemu-block] [PULL v2 0/5] Block patches for 2.9

[Peter Maydell]

On 28 February 2017 at 16:34, Jeff Cody <address@hidden> wrote:
> The following changes since commit c8c0a1a784cdf70ecea50e93213137c6c89337a7:
>
>   Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into 
> staging (2017-02-28 13:41:03 +0000)
>
> are available in the git repository at:
>
>   address@hidden:codyprime/qemu-kvm-jtc.git tags/block-pull-request
>
> for you to fetch changes up to 7a4bdbdd818fba3fb6c79d23baa3c7cb928be661:
>
>   block/rbd: add support for 'mon_host', 'auth_supported' via QAPI 
> (2017-02-28 11:32:46 -0500)
>
> ----------------------------------------------------------------
> Block patches for 2.9 - rbd blockdev-add.  Added s-o-b's.
> ----------------------------------------------------------------

Doesn't build on some compilers:

/home/petmay01/qemu/block/rbd.c: In function 'qemu_rbd_array_opts':
/home/petmay01/qemu/block/rbd.c:605:5: error: 'for' loop initial
declarations are only allowed in C99 or C11 mode
     for (int i = 0; i < num_entries; i++) {
     ^
/home/petmay01/qemu/block/rbd.c:605:5: note: use option -std=c99,
-std=gnu99, -std=c11 or -std=gnu11 to compile your code

Variable declaration has to go at the top of a block,
not inside a for().

thanks
-- PMM