[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 1/2] block: Don't use error_abort in blk_new_open
From: |
Fam Zheng |
Subject: |
[Qemu-block] [PATCH 1/2] block: Don't use error_abort in blk_new_open |
Date: |
Fri, 3 Mar 2017 21:38:15 +0800 |
We have an errp and bdrv_root_attach_child can fail permission check,
error_abort is not the best choice here.
Signed-off-by: Fam Zheng <address@hidden>
---
block/block-backend.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index daa7908..4eab68f 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -213,7 +213,11 @@ BlockBackend *blk_new_open(const char *filename, const
char *reference,
}
blk->root = bdrv_root_attach_child(bs, "root", &child_root,
- perm, BLK_PERM_ALL, blk, &error_abort);
+ perm, BLK_PERM_ALL, blk, errp);
+ if (!blk->root) {
+ blk_unref(blk);
+ return NULL;
+ }
return blk;
}
--
2.9.3