Re: [Qemu-block] [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster

[Peter Maydell]

On 2 March 2017 at 21:43, Markus Armbruster <address@hidden> wrote:
> Bad error handling, memory leaks, and lack of blockdev-add support.
>
> Markus Armbruster (15):
>   sheepdog: Defuse time bomb in sd_open() error handling
>   sheepdog: Fix error handling in sd_snapshot_delete()
>   sheepdog: Fix error handling sd_create()
>   sheepdog: Mark sd_snapshot_delete() lossage FIXME
>   sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()
>   sheepdog: Don't truncate long VDI name in _open(), _create()
>   sheepdog: Report errors in pseudo-filename more usefully
>   sheepdog: Use SocketAddress and socket_connect()
>   sheepdog: Implement bdrv_parse_filename()
>   gluster: Drop assumptions on SocketTransport names
>   gluster: Don't duplicate qapi-util.c's qapi_enum_parse()
>   gluster: Plug memory leaks in qemu_gluster_parse_json()
>   qapi-schema: Rename GlusterServer to SocketAddressFlat
>   qapi-schema: Rename SocketAddressFlat's variant tcp to inet
>   sheepdog: Support blockdev-add
>
>  block/gluster.c      | 127 +++++++--------
>  block/sheepdog.c     | 436 
> +++++++++++++++++++++++++++++++++++++--------------
>  qapi-schema.json     |  38 +++++
>  qapi/block-core.json |  73 +++------
>  4 files changed, 443 insertions(+), 231 deletions(-)

Did you find these by looking at our Coverity results, or
cross-reference them against Coverity? (Coverity definitely
found the gluster leaks, for instance.)

thanks
-- PMM