[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 14/15] qapi-schema: Rename SocketAd
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet |
Date: |
Fri, 3 Mar 2017 12:35:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/02/2017 03:44 PM, Markus Armbruster wrote:
> QAPI type SocketAddressFlat differs from SocketAddress pointlessly:
> the discriminator value for variant InetSocketAddress is 'tcp' instead
> of 'inet'. Rename.
>
> The type is far only used by the Gluster block drivers. Take care to
> keep 'tcp' working there.
The old name was visible in QMP in 2.8, but only by blockdev-add, which
we've already argued was not stable (and where we've already made other
non-back-compat changes to it). But that means this HAS to go into 2.9,
if we're declaring blockdev-add stable for 2.9.
It wouldn't hurt to mention that additional information in the commit
message.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/gluster.c | 59
> +++++++++++++++++++++++++++++---------------------------
> qapi-schema.json | 8 ++++----
> 2 files changed, 35 insertions(+), 32 deletions(-)
>
> +++ b/qapi-schema.json
> @@ -4105,14 +4105,14 @@
> #
> # Available SocketAddressFlat types
> #
> -# @tcp: Internet address
> +# @inet: Internet address
> #
> # @unix: Unix domain socket
Nit: Spacing is now inconsistent.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 15/15] sheepdog: Support blockdev-add, Markus Armbruster, 2017/03/02
[Qemu-block] [PATCH 09/15] sheepdog: Implement bdrv_parse_filename(), Markus Armbruster, 2017/03/02