[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 06/12] migration: Document handling of bdrv_is_alloca
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 06/12] migration: Document handling of bdrv_is_allocated() errors |
Date: |
Mon, 13 Mar 2017 15:55:02 +0100 |
From: Eric Blake <address@hidden>
Migration is the only code left in the tree that does not react
to bdrv_is_allocated() failures. But as there is no useful way
to react to the failure, and we are merely skipping unallocated
sectors on success, just document that our choice of handling
is intended.
Signed-off-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
migration/block.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/block.c b/migration/block.c
index 1941bc2..6741228 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -276,6 +276,8 @@ static int mig_save_device_bulk(QEMUFile *f, BlkMigDevState
*bmds)
if (bmds->shared_base) {
qemu_mutex_lock_iothread();
aio_context_acquire(blk_get_aio_context(bb));
+ /* Skip unallocated sectors; intentionally treats failure as
+ * an allocated sector */
while (cur_sector < total_sectors &&
!bdrv_is_allocated(blk_bs(bb), cur_sector,
MAX_IS_ALLOCATED_SEARCH, &nr_sectors)) {
--
1.8.3.1
- [Qemu-block] [PULL 00/12] Block layer fixes for 2.9.0-rc1, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 01/12] backup: allow target without .bdrv_get_info, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 02/12] file-posix: Consider max_segments for BlockLimits.max_transfer, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 04/12] backup: React to bdrv_is_allocated() errors, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 05/12] vvfat: React to bdrv_is_allocated() errors, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 06/12] migration: Document handling of bdrv_is_allocated() errors,
Kevin Wolf <=
- [Qemu-block] [PULL 03/12] block: Drop unmaintained 'archipelago' driver, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 08/12] block: Request block status from *file for BDRV_BLOCK_RAW, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 10/12] block: Refresh filename after changing backing file, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 07/12] block: Remove check_new_perm from bdrv_replace_child(), Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 09/12] commit: Implement bdrv_commit_top.bdrv_co_get_block_status, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 11/12] mirror: Implement .bdrv_refresh_filename, Kevin Wolf, 2017/03/13
- [Qemu-block] [PULL 12/12] commit: Implement .bdrv_refresh_filename, Kevin Wolf, 2017/03/13
- Re: [Qemu-block] [Qemu-devel] [PULL 00/12] Block layer fixes for 2.9.0-rc1, Peter Maydell, 2017/03/13