[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2] file-posix: Don't leak fd in hd
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2] file-posix: Don't leak fd in hdev_get_max_segments |
Date: |
Tue, 14 Mar 2017 17:28:04 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.03.2017 um 17:20 hat Eric Blake geschrieben:
> On 03/14/2017 11:12 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/file-posix.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/block/file-posix.c b/block/file-posix.c
> > index c4c0663..d670be3 100644
> > --- a/block/file-posix.c
> > +++ b/block/file-posix.c
> > @@ -703,6 +703,9 @@ static int hdev_get_max_segments(const struct stat *st)
> > }
> >
> > out:
> > + if (fd != -1) {
> > + close(fd);
> > + }
>
> Mails crossed - I see I asked about this in reply to v1 after you
> already sent v2 minutes earlier.
>
> I still think it might be nice to mention a commit id that you are
> fixing (one of my reply-to-self on your v1), but either way,
>
> Reviewed-by: Eric Blake <address@hidden>
I added a sentence to the commit message: "This fixes a leaked fd
introduced in commit 9103f1ce." Sounds good?
Kevin
pgpji7Co9brk5.pgp
Description: PGP signature