[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize prealloc
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate() |
|
Date: |
Mon, 20 Mar 2017 11:04:04 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Mar 13, 2017 at 10:40:38PM +0100, Max Reitz wrote:
> This patch adds two new parameters to the preallocate() function so we
> will be able to use it not just for preallocating a new image but also
> for preallocated image growth.
>
> The offset parameter allows the caller to specify a virtual offset from
> which to start preallocating. For newly created images this is always 0,
> but for preallocating growth this will be the old image length.
>
> The new_length parameter specifies the supposed new length of the image
> (basically the "end offset" for preallocation). During image truncation,
> bdrv_getlength() will return the old image length so we cannot rely on
> its return value then.
You documented the arguments in the commit description. Please move
them into doc comments.
signature.asc
Description: PGP signature
- Re: [Qemu-block] [PATCH for-2.10 06/16] block/file-posix: Extract raw_regular_truncate(), (continued)
[Qemu-block] [PATCH for-2.10 08/16] block/file-posix: Preallocation for truncate, Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate(), Max Reitz, 2017/03/13
- Re: [Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate(),
Stefan Hajnoczi <=
[Qemu-block] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate(), Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 11/16] block/qcow2: Metadata preallocation for truncate, Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 12/16] block/qcow2: Extract qcow2_calc_size_usage(), Max Reitz, 2017/03/13
[Qemu-block] [PATCH for-2.10 13/16] block/qcow2: qcow2_calc_size_usage() for truncate, Max Reitz, 2017/03/13