[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/3] qemu-img: print short help on getopt fai
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-block] [PATCH v2 3/3] qemu-img: print short help on getopt failure |
Date: |
Tue, 21 Mar 2017 23:15:26 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Fri, Mar 17, 2017 at 06:45:41PM +0800, Stefan Hajnoczi wrote:
> Printing the full help output obscures the error message for an invalid
> command-line option or missing argument.
>
> Before this patch:
>
> $ ./qemu-img --foo
> ...pages of output...
That gives me:
$ qemu-img --foo
qemu-img: unrecognized option '--foo'
I think you meant any one of the `qemu-img create|convert|... --foo`:
$ qemu-img create --foo
[...]
Which _does_ give "pages of output".
Just noting if you want to tweak the commit message.
> After this patch:
>
> $ ./qemu-img --foo
> qemu-img: unrecognized option '--foo'
> Try 'qemu-img --help' for more information
>
[...]
--
/kashyap