[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 for-2.9 7/9] sockets: New helper socket_addre
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3 for-2.9 7/9] sockets: New helper socket_address_crumple() |
|
Date: |
Thu, 30 Mar 2017 13:02:10 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/30/2017 12:43 PM, Markus Armbruster wrote:
> SocketAddress is a simple union, and simple unions are awkward: they
> have their variant members wrapped in a "data" object on the wire, and
> require additional indirections in C. I intend to limit its use to
> existing external interfaces. New ones should use SocketAddressFlat.
> I further intend to convert all internal interfaces to
> SocketAddressFlat. This helper should go away then.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/qemu/sockets.h | 11 +++++++++++
> util/qemu-sockets.c | 32 ++++++++++++++++++++++++++++++++
> 2 files changed, 43 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature