[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v14 05/20] qemu-img: Update documentation for --
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v14 05/20] qemu-img: Update documentation for --share-rw |
Date: |
Fri, 21 Apr 2017 10:37:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/20/2017 10:55 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> qemu-img-cmds.hx | 48 ++++++++++++++++++++++++------------------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
> index 8ac7822..1b00bb8 100644
> --- a/qemu-img-cmds.hx
> +++ b/qemu-img-cmds.hx
> @@ -10,15 +10,15 @@ STEXI
> ETEXI
>
> DEF("bench", img_bench,
> - "bench [-c count] [-d depth] [-f fmt] [--flush-interval=flush_interval]
> [-n] [--no-drain] [-o offset] [--pattern=pattern] [-q] [-s buffer_size] [-S
> step_size] [-t cache] [-w] filename")
> + "bench [-c count] [-d depth] [-f fmt] [--flush-interval=flush_interval]
> [-n] [--no-drain] [-o offset] [--pattern=pattern] [-q] [-s buffer_size] [-S
> step_size] [-t cache] [-w] [--share-rw] filename")
General comment - it seems that we favor the short-option spelling where
one exists; should all of these updates mention -U instead of --share-rw?
Also, why did you rename it from --unsafe-reads in an earlier revision?
After all, if I'm understanding this flag correctly, what you are asking
for is the ability to read the image in spite of other simultaneous
writers that may make your reads inconsistent.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v14 02/20] qapi: Add 'force-shared-write' to blockdev-add arguments, (continued)
[Qemu-block] [PATCH v14 05/20] qemu-img: Update documentation for --share-rw, Fam Zheng, 2017/04/20
- Re: [Qemu-block] [PATCH v14 05/20] qemu-img: Update documentation for --share-rw,
Eric Blake <=
[Qemu-block] [PATCH v14 06/20] qemu-io: Add --share-rw option, Fam Zheng, 2017/04/20
[Qemu-block] [PATCH v14 07/20] iotests: 030: Prepare for image locking, Fam Zheng, 2017/04/20
[Qemu-block] [PATCH v14 08/20] iotests: 046: Prepare for image locking, Fam Zheng, 2017/04/20
[Qemu-block] [PATCH v14 09/20] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/04/20
[Qemu-block] [PATCH v14 10/20] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/04/20
[Qemu-block] [PATCH v14 11/20] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/04/20