[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/4] qcow2: Fix preallocation size formula
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/4] qcow2: Fix preallocation size formula |
Date: |
Wed, 3 May 2017 19:54:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/03/2017 06:11 PM, Max Reitz wrote:
> When calculating the number of reftable entries, we should actually use
> the number of refblocks and not (wrongly[1]) re-calculate it.
>
> [1] "Wrongly" means: Dividing the number of clusters by the number of
> entries per refblock and rounding down instead of up.
>
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/4] qcow2: Some fixes, Max Reitz, 2017/05/03
- [Qemu-block] [PATCH 1/4] qcow2: Fix preallocation size formula, Max Reitz, 2017/05/03
- Re: [Qemu-block] [PATCH 1/4] qcow2: Fix preallocation size formula,
Eric Blake <=
- [Qemu-block] [PATCH 2/4] qcow2: Reuse preallocated zero clusters, Max Reitz, 2017/05/03
- [Qemu-block] [PATCH 3/4] qcow2: Discard preallocated zero clusters, Max Reitz, 2017/05/03
- [Qemu-block] [PATCH 4/4] iotests: Extend test 066, Max Reitz, 2017/05/03
- Re: [Qemu-block] [PATCH 0/4] qcow2: Some fixes, Kevin Wolf, 2017/05/04