[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 1/7] curl: strengthen assertion in curl_clean_sta
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH v3 1/7] curl: strengthen assertion in curl_clean_state |
Date: |
Mon, 15 May 2017 12:00:53 +0200 |
curl_clean_state should only be called after all AIOCBs have been
completed. This is not so obvious for the call from curl_detach_aio_context,
so assert that.
Cc: address@hidden
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/curl.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index aa6e8cc0e5..010b0604c5 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -532,6 +532,11 @@ static CURLState *curl_init_state(BlockDriverState *bs,
BDRVCURLState *s)
static void curl_clean_state(CURLState *s)
{
+ int j;
+ for (j=0; j < CURL_NUM_ACB; j++) {
+ assert(!s->acb[j]);
+ }
+
if (s->s->multi)
curl_multi_remove_handle(s->s->multi, s->curl);
--
2.12.2
- [Qemu-block] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 1/7] curl: strengthen assertion in curl_clean_state,
Paolo Bonzini <=
- [Qemu-block] [PATCH v3 4/7] curl: split curl_find_state/curl_init_state, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 3/7] curl: avoid recursive locking of BDRVCURLState mutex, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 5/7] curl: convert CURLAIOCB to byte values, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 2/7] curl: never invoke callbacks with s->mutex held, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 7/7] curl: do not do aio_poll when waiting for a free CURLState, Paolo Bonzini, 2017/05/15
- [Qemu-block] [PATCH v3 6/7] curl: convert readv to coroutines, Paolo Bonzini, 2017/05/15
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, no-reply, 2017/05/15
- Re: [Qemu-block] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Max Reitz, 2017/05/15
- Re: [Qemu-block] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Jeff Cody, 2017/05/16
- Re: [Qemu-block] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Richard W.M. Jones, 2017/05/18