[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 03/13] vvfat: fix typos
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 03/13] vvfat: fix typos |
Date: |
Tue, 16 May 2017 15:21:07 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben:
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> block/vvfat.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 002bd86e42..57f2489689 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -404,9 +404,9 @@ static void init_mbr(BDRVVVFATState *s, int cyls, int
> heads, int secs)
> /* FAT12/FAT16/FAT32 */
> /* DOS uses different types when partition is LBA,
> probably to prevent older versions from using CHS on them */
> - partition->fs_type= s->fat_type==12 ? 0x1:
> - s->fat_type==16 ? (lba?0xe:0x06):
> - /*fat_tyoe==32*/ (lba?0xc:0x0b);
> + partition->fs_type = s->fat_type == 12 ? 0x1 :
> + s->fat_type == 16 ? (lba ? 0xe : 0x06) :
> + /*s->fat_type == 32*/ (lba ? 0xc : 0x0b);
>
> real_mbr->magic[0]=0x55; real_mbr->magic[1]=0xaa;
> }
> @@ -806,7 +806,7 @@ static int read_directory(BDRVVVFATState* s, int
> mapping_index)
> (ROOT_ENTRIES - cur) * sizeof(direntry_t));
> }
>
> - /* reget the mapping, since s->mapping was possibly realloc()ed */
> + /* reset the mapping, since s->mapping was possibly realloc()ed */
Are you sure that this was a typo? It seems to make more sense to me as
"re-get" (maybe easer to read with the hyphen).
> mapping = array_get(&(s->mapping), mapping_index);
> first_cluster += (s->directory.next - mapping->info.dir.first_dir_index)
> * 0x20 / s->cluster_size;
Kevin
- [Qemu-block] [PATCH 00/13] vvfat: misc fixes for read-only mode, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 06/13] vvfat: fix field names in FAT12/FAT16 boot sector, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 03/13] vvfat: fix typos, Hervé Poussineau, 2017/05/15
- Re: [Qemu-block] [Qemu-devel] [PATCH 03/13] vvfat: fix typos,
Kevin Wolf <=
- [Qemu-block] [PATCH 04/13] vvfat: rename useless enumeration values, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 07/13] vvfat: always create . and .. entries at first and in that order, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 09/13] vvfat: correctly create base short names for non-ASCII filenames, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 12/13] vvfat: handle KANJI lead byte 0xe5, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 08/13] vvfat: correctly create long names for non-ASCII filenames, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 13/13] vvfat: change OEM name to 'MSWIN4.1', Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16, Hervé Poussineau, 2017/05/15
- [Qemu-block] [PATCH 10/13] vvfat: correctly generate numeric-tail of short file names, Hervé Poussineau, 2017/05/15