[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 18/18] block: make accounting thread-safe
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH 18/18] block: make accounting thread-safe |
Date: |
Tue, 16 May 2017 16:08:37 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, May 11, 2017 at 04:42:08PM +0200, Paolo Bonzini wrote:
> diff --git a/block/accounting.c b/block/accounting.c
> index 0429e31c9f..85890e4fe5 100644
> --- a/block/accounting.c
> +++ b/block/accounting.c
> @@ -35,6 +35,7 @@ static const int qtest_latency_ns = NANOSECONDS_PER_SECOND
> / 1000;
> void block_acct_init(BlockAcctStats *stats, bool account_invalid,
> bool account_failed)
> {
> + qemu_mutex_init(&stats->spin);
Only if you respin this series:
s/spin/lock/
(It's no longer a spinlock.)
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH 12/18] block: access write_gen with atomics, (continued)
- [Qemu-block] [PATCH 12/18] block: access write_gen with atomics, Paolo Bonzini, 2017/05/11
- [Qemu-block] [PATCH 14/18] block: introduce dirty_bitmap_mutex, Paolo Bonzini, 2017/05/11
- [Qemu-block] [PATCH 15/18] migration/block: reset dirty bitmap before reading, Paolo Bonzini, 2017/05/11
- [Qemu-block] [PATCH 17/18] block: introduce block_account_one_io, Paolo Bonzini, 2017/05/11
- [Qemu-block] [PATCH 18/18] block: make accounting thread-safe, Paolo Bonzini, 2017/05/11
- [Qemu-block] [PATCH 16/18] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/05/11
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, no-reply, 2017/05/11
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1, no-reply, 2017/05/11
- Re: [Qemu-block] [PATCH v2 00/18] Block layer thread safety, part 1, Stefan Hajnoczi, 2017/05/16
- Re: [Qemu-block] [PATCH v2 00/18] Block layer thread safety, part 1, Paolo Bonzini, 2017/05/24