[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for opt names |
Date: |
Thu, 25 May 2017 14:21:47 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/25/2017 11:38 AM, Daniel P. Berrange wrote:
> When integrating the crypto support with qcow/qcow2, we don't
> want to use the bare LUKS option names "hash-alg", "key-secret",
> etc. We need to namespace them to match the nested QAPI schema.
>
> e.g. "encrypt.hash-alg", "encrypt.key-secret"
>
> so that they don't clash with any general qcow options at a later
> date.
>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> block/crypto.c | 16 ++++++++--------
> block/crypto.h | 40 ++++++++++++++++++++--------------------
> 2 files changed, 28 insertions(+), 28 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v7 00/20] Convert QCow[2] to QCryptoBlock & add LUKS support, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 01/20] block: expose crypto option names / defs to other drivers, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for opt names, Daniel P. Berrange, 2017/05/25
- Re: [Qemu-block] [PATCH v7 02/20] block: add ability to set a prefix for opt names,
Eric Blake <=
- [Qemu-block] [PATCH v7 03/20] qcow: document another weakness of qcow AES encryption, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 04/20] qcow: require image size to be > 1 for new images, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 05/20] iotests: skip 042 with qcow which dosn't support zero sized images, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 06/20] iotests: skip 048 with qcow which doesn't support resize, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 08/20] qcow: make encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes", Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 09/20] qcow: convert QCow to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/05/25
- [Qemu-block] [PATCH v7 10/20] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/05/25