[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 7/8] block/qcow.c: Fix memory leak in qcow_create()
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 7/8] block/qcow.c: Fix memory leak in qcow_create() |
Date: |
Wed, 7 Jun 2017 19:50:18 +0200 |
From: Peter Maydell <address@hidden>
Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/qcow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow.c b/block/qcow.c
index 95ab123..7bd94dc 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts
*opts, Error **errp)
header_size += backing_filename_len;
} else {
/* special backing file for vvfat */
+ g_free(backing_file);
backing_file = NULL;
}
header.cluster_bits = 9; /* 512 byte cluster to avoid copying
--
1.8.3.1
- [Qemu-block] [PULL 0/8] Block layer patches, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 1/8] block: Fix anonymous BBs in blk_root_inactivate(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 2/8] migration: Inactivate images after .save_live_complete_precopy(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 3/8] migration/block: Clean up BBs in block_save_complete(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 4/8] qemu-iotests: Block migration test, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 5/8] commit: Fix use after free in completion, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 7/8] block/qcow.c: Fix memory leak in qcow_create(),
Kevin Wolf <=
- [Qemu-block] [PULL 6/8] qemu-iotests: Test automatic commit job cancel on hot unplug, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 8/8] block: fix external snapshot abort permission error, Kevin Wolf, 2017/06/07
- Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block layer patches, Peter Maydell, 2017/06/12