[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/3] commit: Fix completion with extra reference
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 1/3] commit: Fix completion with extra reference |
Date: |
Fri, 9 Jun 2017 16:18:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 2017-06-09 13:50, Kevin Wolf wrote:
> commit_complete() can't assume that after its block_job_completed() the
> job is actually immediately freed; someone else may still be holding
> references. In this case, the op blockers on the intermediate nodes make
> the graph reconfiguration in the completion code fail.
>
> Call block_job_remove_all_bdrv() manually so that we know for sure that
> any blockers on intermediate nodes are given up.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/commit.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-block] [PATCH 3/3] qemu-iotests: Test exiting qemu with running job, Max Reitz, 2017/06/09