Re: [Qemu-block] [PATCH v2 0/2] Parse 'filename' option for RBD/iSCSI

[Richard W.M. Jones]

On Wed, Jun 14, 2017 at 08:53:18AM -0400, Jeff Cody wrote:
> Change from v2:
> Add warning message that this is an unsupported option that may
> be deprecated in the future.
> 
> We need to be able to parse the 'filename' option for rbd and iscsi, because
> there may exist images in the wild that have json backing files, that specify
> the filename argument.
> 
> Jeff Cody (2):
>   block/rbd: enable filename option and parsing
>   block/iscsi: enable filename option and parsing
> 
>  block/iscsi.c | 22 +++++++++++++++++++++-
>  block/rbd.c   | 22 +++++++++++++++++++++-
>  2 files changed, 42 insertions(+), 2 deletions(-)

ACK series.

Issuing the warning is a good idea too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org