Re: [Qemu-block] [PATCH v2 7/7] qcow2: Merge the writing of the COW regions with the guest data

[Alberto Garcia]

On Fri 16 Jun 2017 05:31:42 PM CEST, Kevin Wolf wrote:
>> +        /* Make sure that adding both COW regions to the QEMUIOVector
>> +         * does not exceed IOV_MAX */
>> +        if (hd_qiov->niov > IOV_MAX - 2) {
>> +            continue;
>> +        }
>> +
>> +        m->data_qiov = hd_qiov;
>
> I don't think having this side effect is good for a function that is
> called can_xyz(). I'd either call it merge_cow() or move the
> assignment to the caller.

You're right, I think I prefer to move the assignment to the caller for
now.

Berto