[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/4] qapi/qnull: Add own header
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/4] qapi/qnull: Add own header |
Date: |
Fri, 23 Jun 2017 17:55:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 2017-06-22 16:41, Markus Armbruster wrote:
> Max Reitz <address@hidden> writes:
>
>> On 2017-06-21 18:24, Markus Armbruster wrote:
>>> Max Reitz <address@hidden> writes:
>>>
>>>> Reviewed-by: Kevin Wolf <address@hidden>
>>>> Signed-off-by: Max Reitz <address@hidden>
>>>> ---
>>>> include/qapi/qmp/qnull.h | 26 ++++++++++++++++++++++++++
>>>> include/qapi/qmp/qobject.h | 8 --------
>>>> include/qapi/qmp/types.h | 1 +
>>>> qobject/qnull.c | 1 +
>>>> target/i386/cpu.c | 6 +-----
>>>> tests/check-qnull.c | 2 +-
>>>> 6 files changed, 30 insertions(+), 14 deletions(-)
>>>> create mode 100644 include/qapi/qmp/qnull.h
>>>>
>>>> diff --git a/include/qapi/qmp/qnull.h b/include/qapi/qmp/qnull.h
>>>> new file mode 100644
>>>> index 0000000..69555ac
>>>> --- /dev/null
>>>> +++ b/include/qapi/qmp/qnull.h
>>>> @@ -0,0 +1,26 @@
>>>> +/*
>>>> + * QNull Module
>>>> + *
>>>> + * Copyright (C) 2009, 2017 Red Hat Inc.
>>>> + *
>>>> + * Authors:
>>>> + * Luiz Capitulino <address@hidden>
>>>> + *
>>>> + * This work is licensed under the terms of the GNU LGPL, version 2.1 or
>>>> later.
>>>> + * See the COPYING.LIB file in the top-level directory.
>>>
>>> Copy the boilerplate from qnull.c instead, factual correctness.
>>
>> Sorry, will do.
>
> No need to be sorry!
I was when I noticed that it was your authorship I failed to announce. :-)
Max
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH v2 2/4] qapi: Add qobject_is_equal(), Max Reitz, 2017/06/21
[Qemu-block] [PATCH v2 3/4] block: qobject_is_equal() in bdrv_reopen_prepare(), Max Reitz, 2017/06/21
[Qemu-block] [PATCH v2 4/4] iotests: Add test for non-string option reopening, Max Reitz, 2017/06/21