[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG a
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode |
Date: |
Thu, 29 Jun 2017 11:47:49 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.06.2017 um 21:38 hat Eric Blake geschrieben:
> On 06/28/2017 01:47 PM, Stefan Hajnoczi wrote:
> > This patch series fixes qemu-iotests 068. Since commit
> > ea4f3cebc4e0224605ab9dd9724aa4e7768fe372 ("qemu-iotests: 068: test iothread
> > mode") the test case has attempted to use dataplane without -M accel=kvm.
> > Although QEMU is capable of running TCG or qtest with emulated
> > ioeventfd/irqfd
> > we haven't enabled it yet.
> >
> > Unfortunately the virtio test cases fail when ioeventfd is enabled in qtest
> > mode. This is because they make assumptions about virtqueue ISR signalling.
> > They assume that a request is completed when ISR becomes 1. However, the
> > ISR
> > can be set to 1 even though no new request has completed since commit
> > 83d768b5640946b7da55ce8335509df297e2c7cd "virtio: set ISR on dataplane
> > notifications".
> >
> > This issue is solved by introducing a proper qvirtqueue_get_buf() API
> > (similar
> > to the Linux guest drivers) instead of making assumptions about the ISR.
> > Most
> > of the patches update the test cases to use the new API.
> >
> > Stefan Hajnoczi (6):
> > libqos: fix typo in virtio.h QVirtQueue->used comment
> > libqos: add virtio used ring support
> > tests: fix virtio-scsi-test ISR dependence
> > tests: fix virtio-blk-test ISR dependence
> > tests: fix virtio-net-test ISR dependence
> > virtio-pci: use ioeventfd even when KVM is disabled
>
> I'm less familiar with the code in question, so I'll let others review,
> but it did fix the failure of 068 for me.
>
> Tested-by: Eric Blake <address@hidden>
Also passes the virtio-scsi qtest under valgrind for me now.
Tested-by: Kevin Wolf <address@hidden>
pgpIbRO2rEM4T.pgp
Description: PGP signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 2/6] libqos: add virtio used ring support, (continued)
- [Qemu-block] [PATCH 3/6] tests: fix virtio-scsi-test ISR dependence, Stefan Hajnoczi, 2017/06/28
- [Qemu-block] [PATCH 4/6] tests: fix virtio-blk-test ISR dependence, Stefan Hajnoczi, 2017/06/28
- [Qemu-block] [PATCH 5/6] tests: fix virtio-net-test ISR dependence, Stefan Hajnoczi, 2017/06/28
- [Qemu-block] [PATCH 6/6] virtio-pci: use ioeventfd even when KVM is disabled, Stefan Hajnoczi, 2017/06/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode, Eric Blake, 2017/06/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode,
Kevin Wolf <=
- Re: [Qemu-block] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode, Michael S. Tsirkin, 2017/06/29
- Re: [Qemu-block] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode, Stefan Hajnoczi, 2017/06/30