[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 1/2] iotests: Use absolute paths for executab
From: |
Jeff Cody |
Subject: |
Re: [Qemu-block] [PATCH v4 1/2] iotests: Use absolute paths for executables |
Date: |
Fri, 30 Jun 2017 17:48:55 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jun 30, 2017 at 02:45:46PM -0500, Eric Blake wrote:
> On 06/30/2017 02:41 PM, Eric Blake wrote:
>
> > +++ 068.out.bad 2017-06-30 14:35:28.720241398 -0500
> > @@ -1,4 +1,5 @@
> > QA output created by 068
> > +realpath: '': No such file or directory
> >
> > The culprit? $QEMU_VXHS_PROG is empty for me, which means `set_prog_path
> > qnio_server` found nothing to use. You'll have to add in a safety valve
> > that only calls 'type' if operating on a non-empty path in the first place.
>
> I'm using this locally, in the meantime:
>
> diff --git i/tests/qemu-iotests/common.config
> w/tests/qemu-iotests/common.config
> index c1dc425..6f97331 100644
> --- i/tests/qemu-iotests/common.config
> +++ w/tests/qemu-iotests/common.config
> @@ -107,7 +107,9 @@ export QEMU_PROG=$(realpath -- "$(type -p
> "$QEMU_PROG")")
> export QEMU_IMG_PROG=$(realpath -- "$(type -p "$QEMU_IMG_PROG")")
> export QEMU_IO_PROG=$(realpath -- "$(type -p "$QEMU_IO_PROG")")
> export QEMU_NBD_PROG=$(realpath -- "$(type -p "$QEMU_NBD_PROG")")
> -export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")")
> +if [ -n "$QEMU_VXHS_PROG" ]; then
> + export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")")
> +fi
>
> _qemu_wrapper()
> {
>
>
> Is qnio_server easily available for Fedora?
>
Depends on your definition of "easily". It needs to be built from the
upstream project github [1]. Most developers will likely not have it
installed.
https://github.com/VeritasHyperScale/libqnio