[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 24/39] qcow2: Update discard_single_l2() to s
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v3 24/39] qcow2: Update discard_single_l2() to support L2 slices |
Date: |
Fri, 02 Feb 2018 10:46:28 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 01 Feb 2018 08:07:15 PM CET, Max Reitz <address@hidden> wrote:
> On 2018-01-26 15:59, Alberto Garcia wrote:
>> discard_single_l2() limits the number of clusters to be discarded to
>> the amount that fits inside an L2 table. Since we'll be loading L2
>> slices instead of full tables we need to update that limit.
>
> Hmmmm, maybe rename the function to discard_l2_slice() or
> discard_in_l2_slice() or discard_all_in_l2_slice() or
> discard_single_l2_slice()?
Good idea, I think I that will change that (also the related comment in
qcow2_cluster_discard()).
Berto