Re: [Qemu-block] [PULL v2 00/38] Block layer patches

[Peter Maydell]

On 6 March 2018 at 10:24, Kevin Wolf <address@hidden> wrote:
> Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben:
>> On 5 March 2018 at 17:51, Kevin Wolf <address@hidden> wrote:
>> > The following changes since commit 
>> > 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34:
>> >
>> >   Merge remote-tracking branch 
>> > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 
>> > 14:37:10 +0000)
>> >
>> > are available in the git repository at:
>> >
>> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>> >
>> > for you to fetch changes up to bfe1a14c180ec44c033be12b9151252ffda69292:
>> >
>> >   block: Fix NULL dereference on empty drive error (2018-03-05 18:45:32 
>> > +0100)
>> >
>> > ----------------------------------------------------------------
>> > Block layer patches
>> >
>> > ----------------------------------------------------------------
>>
>> This pull turns out to add a bunch of tests that end in the name "error",
>> which triggers my buildlog scanning scripts that look for "error:".
>> Could we rename those?
>
> Wouldn't it make more sense to change your script so that it considers
> "error" only if it's a whole word rather than part of an identifier?
> These test cases concern error paths, so it's kind of expected that
> their name contains "error" as a substring.

Mmm, yes, that turns out not to be too difficult. I've done that.

thanks
-- PMM