[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] block migration and dirty bitmap reset
From: |
Peter Lieven |
Subject: |
[Qemu-block] block migration and dirty bitmap reset |
Date: |
Wed, 7 Mar 2018 09:06:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Hi,
while looking at the code I wonder if the blk_aio_preadv and the
bdrv_reset_dirty_bitmap order must
be swapped in mig_save_device_bulk:
qemu_mutex_lock_iothread();
aio_context_acquire(blk_get_aio_context(bmds->blk));
blk->aiocb = blk_aio_preadv(bb, cur_sector * BDRV_SECTOR_SIZE, &blk->qiov,
0, blk_mig_read_cb, blk);
bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, cur_sector * BDRV_SECTOR_SIZE,
nr_sectors * BDRV_SECTOR_SIZE);
aio_context_release(blk_get_aio_context(bmds->blk));
qemu_mutex_unlock_iothread();
In mig_save_device_dirty we first reset the dirty bitmap and read then which
shoulds like
a better idea. Maybe it doesn't matter while we acquire the aioctx and the
iothread lock...
Peter
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Stefan Hajnoczi, 2018/03/05
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Peter Lieven, 2018/03/05
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Dr. David Alan Gilbert, 2018/03/05
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Stefan Hajnoczi, 2018/03/06
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Peter Lieven, 2018/03/06
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Peter Lieven, 2018/03/07
- [Qemu-block] block migration and dirty bitmap reset,
Peter Lieven <=
- Re: [Qemu-block] block migration and dirty bitmap reset, Fam Zheng, 2018/03/07
- Re: [Qemu-block] block migration and dirty bitmap reset, Peter Lieven, 2018/03/08
- Re: [Qemu-block] block migration and dirty bitmap reset, Fam Zheng, 2018/03/08
- Re: [Qemu-block] block migration and dirty bitmap reset, Peter Lieven, 2018/03/08
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Stefan Hajnoczi, 2018/03/07
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Peter Lieven, 2018/03/07
- Re: [Qemu-block] block migration and MAX_IN_FLIGHT_IO, Peter Lieven, 2018/03/06