[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] nbd/server: Honor FUA request on NBD_CMD_TRIM
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH] nbd/server: Honor FUA request on NBD_CMD_TRIM |
Date: |
Thu, 8 Mar 2018 01:50:52 -0500 (EST) |
> The NBD spec states that since trim requests can affect disk contents,
> then they should allow for FUA semantics just like writes for ensuring
> the disk has settled before returning. As bdrv_[co_]pdiscard() does
> not (yet?) support a flags argument, we can't pass FUA down the block
> layer stack, and must therefore emulate it with a flush at the NBD
> layer.
TRIM requests should not need FUA since they're just advisory. On
the other hand, WRITE ZEROES requests need to support FUA.
Paolo