qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] hmp: Allow using a qdev id in bloc


From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] hmp: Allow using a qdev id in block_set_io_throttle
Date: Fri, 9 Mar 2018 08:52:21 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/09/2018 08:11 AM, Alberto Garcia wrote:
The QMP version of this command can take a qdev ID since 7a9877a02635,
but the HMP version is still using the deprecated block device name so
there's no way to refer to a block device added like this:

   -blockdev 
node-name=disk0,driver=qcow2,file.driver=file,file.filename=hd.qcow2
   -device virtio-blk-pci,id=virtio-blk-pci0,drive=disk0

This patch works around this problem by using the specified name as a
qdev ID if the block device name is not found.

Signed-off-by: Alberto Garcia <address@hidden>
---
  hmp-commands.hx |  3 ++-
  hmp.c           | 14 ++++++++++++--
  2 files changed, 14 insertions(+), 3 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]