[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v8 6/9] file-posix: support BDRV_REQ_ALLOCATE
From: |
Anton Nefedov |
Subject: |
[Qemu-block] [PATCH v8 6/9] file-posix: support BDRV_REQ_ALLOCATE |
Date: |
Mon, 12 Mar 2018 13:16:55 +0300 |
Current write_zeroes implementation is good enough to satisfy this flag too
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/file-posix.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 7f2cc63..2136df9 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -560,7 +560,10 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
}
if (S_ISREG(st.st_mode)) {
s->discard_zeroes = true;
+#ifdef CONFIG_FALLOCATE
s->has_fallocate = true;
+ bs->supported_zero_flags |= BDRV_REQ_ALLOCATE;
+#endif
}
if (S_ISBLK(st.st_mode)) {
#ifdef BLKDISCARDZEROES
@@ -595,10 +598,11 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
#ifdef CONFIG_XFS
if (platform_test_xfs_fd(s->fd)) {
s->is_xfs = true;
+ bs->supported_zero_flags |= BDRV_REQ_ALLOCATE;
}
#endif
- bs->supported_zero_flags = s->discard_zeroes ? BDRV_REQ_MAY_UNMAP : 0;
+ bs->supported_zero_flags |= s->discard_zeroes ? BDRV_REQ_MAY_UNMAP : 0;
ret = 0;
fail:
if (filename && (bdrv_flags & BDRV_O_TEMPORARY)) {
@@ -1416,6 +1420,10 @@ static ssize_t handle_aiocb_write_zeroes(RawPosixAIOData
*aiocb)
}
s->has_fallocate = false;
}
+
+ if (!s->has_fallocate) {
+ aiocb->bs->supported_zero_flags &= ~BDRV_REQ_ALLOCATE;
+ }
#endif
return -ENOTSUP;
--
2.7.4
- [Qemu-block] [PATCH v8 0/9] qcow2: cluster space preallocation, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 2/9] blkverify: set supported write/zero flags, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 1/9] mirror: inherit supported write/zero flags, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 4/9] block: introduce BDRV_REQ_ALLOCATE flag, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 3/9] quorum: set supported write/zero flags, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 9/9] iotest 134: test cluster-misaligned encrypted write, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 6/9] file-posix: support BDRV_REQ_ALLOCATE,
Anton Nefedov <=
- [Qemu-block] [PATCH v8 8/9] qcow2: skip writing zero buffers to empty COW areas, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 5/9] block: treat BDRV_REQ_ALLOCATE as serialising, Anton Nefedov, 2018/03/12
- [Qemu-block] [PATCH v8 7/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers, Anton Nefedov, 2018/03/12