[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/5] block/blkreplay: Remove protocol-related fi
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH 4/5] block/blkreplay: Remove protocol-related fields |
|
Date: |
Mon, 12 Mar 2018 14:45:16 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-03-09 19:22, Fabiano Rosas wrote:
> The blkreplay driver is not a protocol so it should implement bdrv_open
> instead of bdrv_file_open and not provide a protocol_name.
>
> Attempts to invoke this driver using protocol syntax
> (i.e. blkreplay:<filename:options:...>) will now fail gracefully:
>
> $ qemu-img info blkreplay:foo
> qemu-img: Could not open 'blkreplay:foo': Unknown protocol 'blkreplay'
>
> Signed-off-by: Fabiano Rosas <address@hidden>
> ---
> block/blkreplay.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Fabiano Rosas, 2018/03/09
- [Qemu-block] [PATCH 3/5] block/throttle: Remove protocol-related fields, Fabiano Rosas, 2018/03/09
- [Qemu-block] [PATCH 5/5] include/block/block_int: Document protocol related functions, Fabiano Rosas, 2018/03/09
- [Qemu-block] [PATCH 4/5] block/blkreplay: Remove protocol-related fields, Fabiano Rosas, 2018/03/09
- [Qemu-block] [PATCH 1/5] block/replication: Remove protocol_name field, Fabiano Rosas, 2018/03/09
- [Qemu-block] [PATCH 2/5] block/quorum: Remove protocol-related fields, Fabiano Rosas, 2018/03/09