[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function r
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value |
|
Date: |
Thu, 22 Mar 2018 10:19:29 -0700 |
On Thu, Mar 22, 2018 at 9:58 AM, Laurent Vivier <address@hidden> wrote:
> On 22/03/2018 17:51, Max Filippov wrote:
>> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier <address@hidden> wrote:
>>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> ---
>>> target/xtensa/core-dc232b/xtensa-modules.c | 56
>>> ++++++----------------
>>> target/xtensa/core-dc233c/xtensa-modules.c | 56
>>> ++++++----------------
>>> target/xtensa/core-de212/xtensa-modules.c | 48 +++++--------------
>>> target/xtensa/core-fsf/xtensa-modules.c | 32 ++++---------
>>> .../xtensa/core-sample_controller/xtensa-modules.c | 24 +++-------
>>
>> These files were autogenerated, fixing them doesn't make much sense.
>
> Good to know. They have been already updated by a couple of patches:
>
> 8f0a3716e4 Clean up includes
> d8e39b7062 Use #include "..." for our own headers, <...> for others
>
> Perhaps import_core.sh can be updated?
Ok, I can add a fixup that changes #include <xtensa-isa.h> to #include
"xtensa-isa.h".
Adding #include "qemu/osdep.h" there seems pointless to me.
--
Thanks.
-- Max
Re: [Qemu-block] [Qemu-arm] [PATCH 4/4] Remove unnecessary variables for function return value, Philippe Mathieu-Daudé, 2018/03/22
Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value, David Gibson, 2018/03/22
Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value, Alberto Garcia, 2018/03/23
Re: [Qemu-block] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle, Eric Blake, 2018/03/22