[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] qemu-pr-helper: Actually
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] qemu-pr-helper: Actually allow users to specify pidfile |
|
Date: |
Mon, 26 Mar 2018 13:10:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 24/03/2018 12:46, Eric Blake wrote:
> On 03/24/2018 12:14 AM, Michal Privoznik wrote:
>> Due to wrong specification of arguments to getopt_long() any
>> attempt to set pidfile resulted in:
>>
>> 1) the default to be leaked
>> 2) the @pidfile variable to be set to NULL (because optarg is
>> NULL without this patch).
>
> Broken since the introduction in commit b855f8d, in 2.11 (documentation
> has always mentioned the argument, code has never supported it).
Queued, thanks.
Paolo
>>
>> Signed-off-by: Michal Privoznik <address@hidden>
>
> CC: address@hidden
> Reviewed-by: Eric Blake <address@hidden>
>