[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 16/67] migration: use local path for local heade
From: |
Juan Quintela |
Subject: |
Re: [Qemu-block] [PATCH 16/67] migration: use local path for local headers |
Date: |
Tue, 08 May 2018 14:21:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
No, it is not by accident.
qemu-version.h and config-host.h are on the root directory. I could
agree with moving them.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> migration/block-dirty-bitmap.c | 2 +-
> migration/page_cache.c | 2 +-
> migration/ram.c | 4 ++--
> migration/vmstate.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
> index dd04f10..09c086d 100644
> --- a/migration/block-dirty-bitmap.c
> +++ b/migration/block-dirty-bitmap.c
> @@ -66,7 +66,7 @@
> #include "qemu/error-report.h"
> #include "migration/misc.h"
> #include "migration/migration.h"
> -#include "migration/qemu-file.h"
> +#include "qemu-file.h"
Substitite for "./qemu-file.h"?
My wonder here is what happens if we end with a file with the same name in
two places.
Later, Juan.