[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 37/42] job: Move progress fields to Job
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 37/42] job: Move progress fields to Job |
Date: |
Mon, 14 May 2018 23:33:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-09 18:26, Kevin Wolf wrote:
> BlockJob has fields .offset and .len, which are actually misnomers today
> because they are no longer tied to block device sizes, but just progress
> counters. As such they make a lot of sense in generic Jobs.
>
> This patch moves the fields to Job and renames them to .progress_current
> and .progress_total to describe their function better.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/block/blockjob.h | 25 -------------------------
> include/qemu/job.h | 27 +++++++++++++++++++++++++++
> block/backup.c | 8 ++++----
> block/commit.c | 4 ++--
> block/mirror.c | 4 ++--
> block/stream.c | 4 ++--
> blockjob.c | 26 ++++++++------------------
> job.c | 10 ++++++++++
> qemu-img.c | 8 ++++++--
> 9 files changed, 61 insertions(+), 55 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 40/42] job: Add query-jobs QMP command, Kevin Wolf, 2018/05/09
[Qemu-block] [PATCH 41/42] iotests: Move qmp_to_opts() to VM, Kevin Wolf, 2018/05/09