|
From: | John Snow |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands |
Date: | Wed, 23 May 2018 19:56:23 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/18/2018 09:21 AM, Kevin Wolf wrote: > +{ 'command': 'job-complete', 'data': { 'id': 'str' } } Do we have to name it this? I've always disliked how "complete" is used as both a verb and an adjective in our code (hence why I used such bizarre phrasings like "concluded" in my jobs patches) ... I don't necessarily have a better suggestion, but now's the chance to ask the question. I guess you don't have a better suggestion either, otherwise you'd have changed it. --js
[Prev in Thread] | Current Thread | [Next in Thread] |