[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 4/5] qcow2: Set the default cache-clean-inter
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes |
Date: |
Thu, 09 Aug 2018 12:58:44 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 09 Aug 2018 12:52:34 PM CEST, Leonid Bloch wrote:
> On 8/9/18 12:33 PM, Alberto Garcia wrote:
>> On Thu 09 Aug 2018 12:11:37 AM CEST, Leonid Bloch wrote:
>>> The default cache-clean-interval is set to 10 minutes, in order to lower
>>> the overhead of the qcow2 caches (before the default was 0, i.e.
>>> disabled).
>>>
>>> Signed-off-by: Leonid Bloch <address@hidden>
>>
>>> --- a/qapi/block-core.json
>>> +++ b/qapi/block-core.json
>>> @@ -2830,7 +2830,8 @@
>>> #
>>> # @cache-clean-interval: clean unused entries in the L2 and refcount
>>> # caches. The interval is in seconds. The default
>>> value
>>> -# is 0 and it disables this feature (since 2.5)
>>> +# is 600. Setting 0 disables this feature. (since
>>> 2.5)
>>> +#
>>
>> It should be "Setting it to 0 ...".
>
> How about:
>
> "... is 600 (0 disables this feature). (since 2.5)"?
Or "The default is 600, and 0 disables this feature". It's ok either
way.
Berto
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, (continued)
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, Leonid Bloch, 2018/08/09
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, Alberto Garcia, 2018/08/09
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, Leonid Bloch, 2018/08/09
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, Eric Blake, 2018/08/09
- Re: [Qemu-block] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size, Leonid Bloch, 2018/08/09
[Qemu-block] [PATCH v4 3/5] qcow2: Resize the cache upon image resizing, Leonid Bloch, 2018/08/08
[Qemu-block] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes, Leonid Bloch, 2018/08/08
[Qemu-block] [PATCH v4 5/5] qcow2: Explicit number replaced by a constant, Leonid Bloch, 2018/08/08